Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc: update PR template #1437

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Misc: update PR template #1437

merged 1 commit into from
Jun 10, 2024

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Jun 9, 2024

Pull Request Description

This PR removes the requirement for changelog, and adds a new requirement when adding new packages to the project!

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

micahmo
micahmo approved these changes Jun 9, 2024
View reviewed changes
Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit b2be10c into develop Jun 10, 2024
1 check passed
@hjiangsu hjiangsu deleted the misc/update-pr-template branch June 10, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahmo micahmo micahmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjiangsu @micahmo